-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #26
base: master
Are you sure you want to change the base?
Update README.md #26
Conversation
## Modules that have been exported to AzerothCore | ||
|
||
- `mod-arena-solo-3v3` => [mod-arena-3v3-solo-queue](https://github.com/azerothcore/mod-arena-3v3-solo-queue) | ||
- `mod-xp-rates` => [mod-chromie-xp](https://github.com/azerothcore/mod-chromie-xp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if these modules are the same, moreover I think that we are missing some modules in the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're referng to the Modules exported to AC list, since i wasnt there when AS was a thing i dont know what their behaviour was e.g Guild house one they are few and that know what would match if any what existed back then.
I assumed that the modules used in CC that existed in AS would be the successors even if they are complety differnt currently (but achieved the same at the time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that the modules used in CC that existed in AS would be the successors even if they are complety differnt currently (but achieved the same at the time)
This is partially true, but I am not sure about the mod-xp-rates, about guildhouse in AS we did also "personal house" not only related to guild, so I am not sure if the guildhouse modules match properly the on inside mod-azerothshard.
By the way, yehonal should know, when he will be able to review this he can give a proper feedback 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure https://github.com/azerothcore/mod-chromie-xp is exactly the same. The xp mod from CC was also integrated into the smarstone. But maybe we can still add the mod-chromie-xp as a possible replacement although it's not 1:1
Btw, I'm not sure if I understood the question fully
We could archive this, it will not be updated, it's better to split the content into multiple modules. However, at the same time it's better to keep it open so someone can start a discussion via issues or PRs until we don't migrate all the code into other modules |
I don't know if offically AS will be touched again since i see that pieces of this are still be used nowadays.
I tried seeing all exisitng modules in AC and CC that reflect the old ones (not being part of AS im not sure what they did at the time).
Do you think this also can be archieved?
CC @Helias