Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Core/Misc): Remove deprecated code #19413

Merged

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Jul 16, 2024

  • Config - Deprecated for 3 years
  • ChatCommand - Deprecated for 2 years
  • getLevel() - Deprecated for 2 years
  • SendGlobalText - Deprecated for 8 years +

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Sorry, something went wrong.

* Config - Deprecated for 3 years
* ChatCommand - Deprecated for 2 years
* getLevel() - Deprecated for 2 years
* SendGlobalText - Deprecated for 8 years +
@github-actions github-actions bot added CORE Related to the core Script UnitTests file-cpp Used to trigger the matrix build labels Jul 16, 2024
@IntelligentQuantum
Copy link
Member

@Kitzunu Build

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 18, 2024

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 18, 2024

@sudlud
Copy link
Member

sudlud commented Jul 18, 2024

now mod-autobalance is failing

edit: but this is not your fault probably

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 18, 2024

you are failing

@Kitzunu
Copy link
Member Author

Kitzunu commented Jul 18, 2024

azerothcore/mod-autobalance#185 merge it

Kitzunu added a commit to azerothcore/mod-pvpstats-announcer that referenced this pull request Jul 19, 2024
@IntelligentQuantum IntelligentQuantum merged commit 21f86d1 into azerothcore:master Jul 20, 2024
20 of 21 checks passed
@Kitzunu Kitzunu deleted the remove-deprecated-code branch July 20, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Script To Be Merged UnitTests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants