NET Framework 3.0 Change #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirasunt
commented
Sep 20, 2021
pirasunt
commented
- This PR represents changes to the Mono.Addins project so that it can target .NET Framework V3
- The purpose of this change is so that this Addin can be used in .NET 3.0 projects
- This includes updating HashSets to Lists, removing unused methods, etc
| { | ||
| string sid = desc.AddinId + " " + desc.Domain; | ||
| if (!inserted.Add (sid)) | ||
| if (inserted.Contains (sid)) |
There was a problem hiding this comment.
You do not add here, which means you may see more cases where you contain it than you should.
| @@ -56,7 +56,7 @@ public void VisitFolder (IProgressStatus monitor, string path, string domain, bo | |||
| void VisitFolderInternal (IProgressStatus monitor, string path, string domain, bool recursive) | |||
| { | |||
| // Avoid folders including each other | |||
| if (!visitedFolders.Add (path) || ScanContext.IgnorePath (path)) | |||
| if (visitedFolders.Contains (path) || ScanContext.IgnorePath (path)) | |||
|
|
||
| try | ||
| { | ||
| Version av = new Version(dirName.Substring(1, i - 1)); |
There was a problem hiding this comment.
dirName.Substring could theorically fail silently here, whereas it could not before.
| foreach (var prop in properties) | ||
| { | ||
| var stringToCheck = prop.Name + " " + prop.Locale; | ||
| if (props.Contains(stringToCheck)) |
| @@ -805,7 +805,7 @@ internal void ActivateRoots () | |||
|
|
|||
| void CheckHostAssembly (Assembly asm) | |||
| { | |||
| if (AddinDatabase.RunningSetupProcess || asm is System.Reflection.Emit.AssemblyBuilder || asm.IsDynamic) | |||
| if (AddinDatabase.RunningSetupProcess || asm is System.Reflection.Emit.AssemblyBuilder || asm.ManifestModule is System.Reflection.Emit.ModuleBuilder) | |||
There was a problem hiding this comment.
I'm not 100% convinced here, some people seem to disagree on this in stackoverflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.