Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-174-Error-using-ChatGPT-assistant #43

Merged
merged 13 commits into from
May 7, 2024

Conversation

tutn-axonivy
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Test Results

7 tests  +7   7 ✅ +7   12s ⏱️ +12s
2 suites +2   0 💤 ±0 
2 files   +2   0 ❌ ±0 

Results for commit 8b039fa. ± Comparison against base commit aaa0bc0.

♻️ This comment has been updated with latest results.

@tutn-axonivy tutn-axonivy requested a review from ivy-rew April 11, 2024 09:33
@tutn-axonivy
Copy link
Contributor Author

Hi @ivy-rew, I tried many times but cannot make the script pass. Could you help me find out why it is fail? Thanks.

@ivy-rew
Copy link
Member

ivy-rew commented Apr 11, 2024

Hi @ivy-rew, I tried many times but cannot make the script pass. Could you help me find out why it is fail? Thanks.

on 'master' there are new bundles which you need to add to 'manifest.mf' as dependency. see the new rest projects in my screenshot:
maybe you can add them as 'optional' dependency, to work around the fact, that they don't exist on LTS10.
If not, we'll need to maintain a release/10.0 branch ... and update the master to comply with '11.3' nightlies.
new-rest-bundles

Copy link
Contributor

@ntqdinh-axonivy ntqdinh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM

@tutn-axonivy tutn-axonivy merged commit cc12f4a into master May 7, 2024
7 checks passed
@tutn-axonivy tutn-axonivy deleted the bugfix/MARP-174-Error-using-ChatGPT-assistant branch May 7, 2024 04:24
@ivy-rew ivy-rew mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants