Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-1874 New Connector: Access to snowflake #481

Merged

Conversation

phhung-axonivy
Copy link
Contributor

No description provided.

Copy link

Test Results

12 tests  ±0   10 ✅  - 2   36s ⏱️ -6s
 3 suites ±0    0 💤 ±0 
 3 files   ±0    2 ❌ +2 

For more details on these failures, see this check.

Results for commit 4deffb6. ± Comparison against base commit aa7c5aa.

Copy link

github-actions bot commented Feb 12, 2025

Test Results

12 tests  ±0   11 ✅ ±0   23s ⏱️ +5s
 3 suites ±0    0 💤 ±0 
 3 files   ±0    1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 27a162e. ± Comparison against base commit ae22ad1.

♻️ This comment has been updated with latest results.

@phhung-axonivy
Copy link
Contributor Author

Hi @ivy-sgi
Could you please help me to review the meta.json file?

Copy link
Member

@ivy-sgi ivy-sgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! I have added the German translation.

@phhung-axonivy
Copy link
Contributor Author

@ivy-sgi
Thanks for your feedback.
I updated the meta json file.
If it looks good now, could you please help me approve it?

Copy link
Member

@ivy-sgi ivy-sgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phhung-axonivy phhung-axonivy merged commit 703f739 into master Feb 14, 2025
4 of 5 checks passed
@phhung-axonivy phhung-axonivy deleted the feature/MARP-1874-New-Connector-Access-to-snowflake branch February 14, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants