Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): ensure error.cause is serialized #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stefanosala
Copy link

I've just noticed that error.cause is not serialized when sending logs to axiom, this PR will correct that as I feel this is a pretty important part of the error to log.

What do you think?

Copy link

vercel bot commented Jan 16, 2025

@stefanosala is attempting to deploy a commit to the AxiomFM Team on Vercel.

A member of the Team first needs to authorize it.

@dasfmi
Copy link
Collaborator

dasfmi commented Feb 7, 2025

@stefanosala thanks for taking care of this, the change looks good, there are some linting issues though.

@stefanosala
Copy link
Author

@dasfmi thanks for reviewing my patch. To fix those linting issues I had to include es2022 to the typescript config since Error.prototype.cause has been introduced there. Let me know if that's ok or we need to find a workaround.

@dasfmi
Copy link
Collaborator

dasfmi commented Feb 11, 2025

@dasfmi thanks for reviewing my patch. To fix those linting issues I had to include es2022 to the typescript config since Error.prototype.cause has been introduced there. Let me know if that's ok or we need to find a workaround.

Doesn't seems to be a big issue, I am fine with that.

@stefanosala
Copy link
Author

Sorry, fixed another issue with prettier that I didn't catch earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants