Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle cases where document is null in getTables #16

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

mediaupstream
Copy link
Contributor

this is to address an edge case where document can sometimes be undefined, issue: AXM-2504.

NOTE: do we need to build and publish these changes? I wonder what's required for getting this change into the frontend

@kevinehosford
Copy link
Contributor

kevinehosford commented Feb 12, 2024

Nice job! Yes, you can build this by running this script from within the package dir:

"make_package": "npm run prepublishOnly && cp ./package.json ../package.json && cp -r ./release ../",
.

When this lands, update app/frontend/package.json monaco-kuto dependency to point to the latest git commit:
https://github.com/axiomhq/app/blob/615599ab28dba23449e86566f6093c4fcef16eb0/frontend/package.json#L23

@mediaupstream mediaupstream merged commit 3ba1836 into master Feb 13, 2024
1 check passed
@mediaupstream mediaupstream deleted the axm-2504-undefined-syntax branch February 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants