-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Axiom Cloudwatch Forwarder #73
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
Co-authored-by: Dominic Chapman <[email protected]>
…r-log-group Create permission statement for each log group
Co-authored-by: a-khaledf <[email protected]>
Migrate to using `*` instead of log group names in Forwarder permissions as the individual permissions can hit the AWS lambda permission size of 20KB. Trying to solve this will lead to complicate the setup and hurt the DX badly.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the naming of CloudFormation stack elements to make their purpose clearer, and allows greater flexibility in filtering log groups that are applied as subscription filters to the (newly named) Lambda Forwarder, now using a combination of names, prefix and regular expression. It also introduces versioning to the CloudFormation stacks so breaking changes do not impact users, and introduces a new Unsubscriber stack for convenience.
TODO:
/aws/axiom
to easily discard them from being forwarded