pruneSnapshot: prune old, unused snapshots

cmd/ronin/dbcmd.go: pruneSnapshot: add command to prune all old snapshots, keeping just some latest snapshots
cmd/utils/flags.go: add SnapshotKeepAfterPruningFlag to configure number of latest snapshots kept after pruning
consortium/v2/snapshot.go: prune nSnapshotPrune starting from 5 days ago back to older

cmd/ronin/dbcmd.go

@@ -18,6 +18,7 @@ package main
 
 import (
 	"bytes"
+	"encoding/json"
 	"errors"
 	"fmt"
 	"os"
@@ -32,6 +33,7 @@ import (
 	"github.com/ethereum/go-ethereum/cmd/utils"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/common/hexutil"
+	v2 "github.com/ethereum/go-ethereum/consensus/consortium/v2"
 	"github.com/ethereum/go-ethereum/console/prompt"
 	"github.com/ethereum/go-ethereum/core/rawdb"
 	"github.com/ethereum/go-ethereum/ethdb"
@@ -69,6 +71,7 @@ Remove blockchain and state databases`,
 			dbDumpFreezerIndex,
 			dbImportCmd,
 			dbExportCmd,
+			dbPruneConsortiumSnapshotCmd,
 		},
 	}
 	dbInspectCmd = &cli.Command{
@@ -243,6 +246,20 @@ WARNING: This is a low-level operation which may cause database corruption!`,
 		},
 		Description: "Exports the specified chain data to an RLP encoded stream, optionally gzip-compressed.",
 	}
+	dbPruneConsortiumSnapshotCmd = &cli.Command{
+		Name:     "prune-consortium-snapshot",
+		Usage:    "Prune all snapshots except the latest ones",
+		Action:   pruneSnapshot,
+		Category: "MISCELLANEOUS COMMANDS",
+		Flags: []cli.Flag{
+			utils.SnapshotKeepAfterPruningFlag,
+			utils.DataDirFlag,
+		},
+		Description: `
+Prune all consortium snapshots except the latest ones. The number of snapshots to keep
+can be specified via "--snapshot.keep-after-pruning" flag. The default value is 10.
+`,
+	}
 )
 
 func removeDB(ctx *cli.Context) error {
@@ -695,3 +712,60 @@ func exportChaindata(ctx *cli.Context) error {
 	db := utils.MakeChainDatabase(ctx, stack, true)
 	return utils.ExportChaindata(ctx.Args().Get(1), kind, exporter(db), stop)
 }
+
+func pruneSnapshot(ctx *cli.Context) error {
+	keep := ctx.Int(utils.SnapshotKeepAfterPruningFlag.Name)
+	if keep < 0 {
+		log.Error("Invalid keep value", "keep", keep)
+		return errors.New("invalid keep value")
+	}
+	log.Info("Snapshot pruning", "latest snapshots keep: ", keep)
+	// Open the chain database
+	stack, _ := makeConfigNode(ctx)
+	defer stack.Close()
+
+	db := utils.MakeChainDatabase(ctx, stack, false)
+
+	// Get all snapshots (hash, block number) from the database
+	nSnapshots := 0
+	snapshots := make(map[common.Hash]uint64)
+	it := db.NewIterator(rawdb.ConsortiumSnapshotPrefix, nil)
+	defer it.Release()
+	for it.Next() {
+		snap := new(v2.Snapshot)
+		if err := json.Unmarshal(it.Value(), snap); err != nil {
+			return err
+		}
+		snapshots[snap.Hash] = snap.Number
+		nSnapshots++
+	}
+	log.Info("Found all snapshots", "nSnapshots", nSnapshots)
+
+	// Sort the snapshots by block number
+	hashes := make([]common.Hash, 0, nSnapshots)
+	for hash := range snapshots {
+		hashes = append(hashes, hash)
+	}
+	sort.Slice(hashes, func(i, j int) bool {
+		return snapshots[hashes[i]] < snapshots[hashes[j]]
+	})
+
+	// Prune the snapshots
+	if nSnapshots < keep {
+		keep = nSnapshots
+	}
+	nSnapshotsPrune := nSnapshots - keep
+	batch := db.NewBatch()
+	for i := 0; i < nSnapshotsPrune; i++ {
+		if err := batch.Delete(append(rawdb.ConsortiumSnapshotPrefix, hashes[i][:]...)); err != nil {
+			log.Error("Failed to delete snapshot", "hash", hashes[i], "err", err)
+			return err
+		}
+	}
+	if err := batch.Write(); err != nil {
+		log.Error("Failed to write batch", "err", err)
+		return err
+	}
+	log.Info("Pruned snapshots", "snapshots", nSnapshotsPrune)
+	return nil
+}

cmd/utils/flags.go

@@ -1073,6 +1073,12 @@ var (
 		Usage:    "List of mock bls public keys which are reflect 1:1 with mock.validators",
 		Category: flags.MockCategory,
 	}
+
+	SnapshotKeepAfterPruningFlag = &cli.IntFlag{
+		Name:  "snapshot.keep-after-pruning",
+		Usage: "The number of lastest snapshots to keep after pruning (default 50)",
+		Value: 200 * 144,
+	}
 )
 
 // MakeDataDir retrieves the currently requested data directory, terminating

consensus/consortium/v2/snapshot.go

@@ -16,6 +16,7 @@ import (
 	blsCommon "github.com/ethereum/go-ethereum/crypto/bls/common"
 	"github.com/ethereum/go-ethereum/ethdb"
 	"github.com/ethereum/go-ethereum/internal/ethapi"
+	"github.com/ethereum/go-ethereum/log"
 	"github.com/ethereum/go-ethereum/params"
 	lru "github.com/hashicorp/golang-lru"
 )
@@ -112,12 +113,58 @@ func loadSnapshot(
 	return snap, nil
 }
 
+// snapshot pruning
+// delete the nSnapshotsPrune oldest snapshots
+func pruneSnapshot(db ethdb.Database, nSnapshotsPrune int) error {
+	// Get all snapshots (hash, block number) from the database
+	nSnapShots := 0
+	snapshots := make(map[common.Hash]uint64)
+	it := db.NewIterator(rawdb.ConsortiumSnapshotPrefix, nil)
+	defer it.Release()
+	for it.Next() {
+		snap := new(Snapshot)
+		if err := json.Unmarshal(it.Value(), snap); err != nil {
+			return err
+		}
+		snapshots[snap.Hash] = snap.Number
+		nSnapShots++
+	}
+
+	// Sort the snapshots by block number
+	hashes := make([]common.Hash, 0, nSnapShots)
+	for hash := range snapshots {
+		hashes = append(hashes, hash)
+	}
+	sort.Slice(hashes, func(i, j int) bool {
+		return snapshots[hashes[i]] < snapshots[hashes[j]]
+	})
+
+	// Prune the snapshots
+	if nSnapshotsPrune > nSnapShots {
+		nSnapshotsPrune = nSnapShots - 1
+	}
+	for i := 0; i < nSnapshotsPrune; i++ {
+		if err := db.Delete(append(rawdb.ConsortiumSnapshotPrefix, hashes[i][:]...)); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 // store inserts the snapshot into the database.
 func (s *Snapshot) store(db ethdb.Database) error {
 	blob, err := json.Marshal(s)
 	if err != nil {
 		return err
 	}
+	// prune nSnapshotPrune snapshots every prunePeriod blocks
+	nSnapshotsPrune := 200 * 144 // 1 day
+	prunePeriod := 200 * 144     // 1 day
+	if s.Number%uint64(prunePeriod) == 0 {
+		if err := pruneSnapshot(db, nSnapshotsPrune); err != nil {
+			log.Error("Failed to prune snapshots", "err", err)
+		}
+	}
 	return db.Put(append(rawdb.ConsortiumSnapshotPrefix, s.Hash[:]...), blob)
 }