Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migration-script): implement refactor-migration-script #21

Merged
merged 1 commit into from
Dec 19, 2023
Merged

feat(migration-script): implement refactor-migration-script #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions script/BaseMigration.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ abstract contract BaseMigration is ScriptExtended {
}
}

function loadContract(TContract contractType) public virtual returns (address payable contractAddr) {
function loadContract(TContract contractType) public view virtual returns (address payable contractAddr) {
return CONFIG.getAddressFromCurrentNetwork(contractType);
}

Expand All @@ -67,7 +67,7 @@ abstract contract BaseMigration is ScriptExtended {
}

function _getProxyAdmin() internal view virtual returns (address payable proxyAdmin) {
proxyAdmin = CONFIG.getAddressFromCurrentNetwork(DefaultContract.ProxyAdmin.key());
proxyAdmin = loadContract(DefaultContract.ProxyAdmin.key());
}

function _deployImmutable(TContract contractType) internal virtual returns (address payable deployed) {
Expand Down
Loading