-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rework): implement fix-bug
#163
Conversation
566902b
to
b3a3d22
Compare
@@ -205,7 +205,7 @@ library LibDeploy { | |||
DeployInfo memory proxyInfo; | |||
proxyInfo.callValue = callValue; | |||
proxyInfo.by = implInfo.by; | |||
proxyInfo.contractName = "TransparentProxyOZv4_9_5"; | |||
proxyInfo.contractName = "RoninTransparentProxy"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new proxy should be audited before going live
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should bring the unit tests for the Transparent Proxy from OZ into here to ensure the logic behaves as expected
…adapt new forge version when generating storage layout
Co-authored-by: HuyHuynh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
PR to merge from implement-feature/rework/fix-bug to feature/rework.