Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rework): implement fix-bug #163

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

github-actions[bot]
Copy link

Description

PR to merge from implement-feature/rework/fix-bug to feature/rework.

@TuDo1403 TuDo1403 force-pushed the implement-feature/rework/fix-bug branch from 566902b to b3a3d22 Compare October 18, 2024 08:15
generate-artifact.sh Outdated Show resolved Hide resolved
@@ -205,7 +205,7 @@ library LibDeploy {
DeployInfo memory proxyInfo;
proxyInfo.callValue = callValue;
proxyInfo.by = implInfo.by;
proxyInfo.contractName = "TransparentProxyOZv4_9_5";
proxyInfo.contractName = "RoninTransparentProxy";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new proxy should be audited before going live

Copy link
Contributor

@huyhuynh3103 huyhuynh3103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should bring the unit tests for the Transparent Proxy from OZ into here to ensure the logic behaves as expected

TuDo1403 and others added 2 commits January 2, 2025 15:22
…adapt new forge version when generating storage layout
Copy link
Contributor

@huyhuynh3103 huyhuynh3103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huyhuynh3103 huyhuynh3103 merged commit 3411ed3 into feature/rework Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants