Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge latest feature into 'release/v0.1.0' #12

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

TuDo1403
Copy link
Collaborator

@TuDo1403 TuDo1403 commented Dec 15, 2023

Description

This PR merges following feature to 'release/v0.1.0'.

Feature

  • Allow current ProxyAdmin on <ronin-mainnet|ronin-testnet> to interact with @OpenzeppelinV5 TransparentUpgradeableProxy.
  • Remove duplicate logging in BaseMigration:_upgradeProxy(TContract, bytes memory).
  • Expose IWalletConfig:getSenderPk() for signing functionality.
  • Move reusable libraries into contract-libs (LibErrorHandler, LibNativeTransfer).
  • Allow skiping null check in LibProxy.
  • Cheat to load OnchainDebugger into parent directory for debugging.
  • Add BaseMigration:_postCheck for future use.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

…migration-script

chore(`migration-script`): merge from `release/v0.1.0`
…pgradeableProxy with upgradeTo & null check ProxyAdmin & expose get sender pk for signing
…script/refactor-migration-script

feat(migration-script): implement `refactor-migration-script`
…script/refactor-migration-script

feat(migration-script): implement `refactor-migration-script`
@TuDo1403 TuDo1403 merged commit 4f8d011 into release/v0.1.0 Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant