[Tests] Unit Tests Guide #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin852
changed the title
npty
reviewed
Mar 5, 2024
StephenFluin
suggested changes
Mar 7, 2024
examples/evm/call-contract-with-token/tests/call-contract-with-token.test.js
Outdated
Show resolved
Hide resolved
| @@ -36,6 +36,9 @@ | |||
| "uuid": "^8.3.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@nomicfoundation/hardhat-chai-matchers": "^1.0.0", | |||
There was a problem hiding this comment.
I think these test should be deps, not dev deps, but open to discussion. My definition of dev deps are things that you need if you are WORKING on the examples. Every developer that wants to USE the examples will need these deps, right?
There was a problem hiding this comment.
If I move hardhat-chai-matchers to dependencies would it no make sense at that point to move chai and hardhat-ethers as well?
StephenFluin
approved these changes
Mar 26, 2024
benjamin852
force-pushed
the
test/testing-examples
branch
from
38d985c to
567f80d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for some of our examples to serve as a guide for writing tests with axelarjs. Tests include
Also added readme for the canonical ITS token example.