Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of hardcoded DaemonSet tolerations #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jon-rei
Copy link

@jon-rei jon-rei commented Jan 21, 2025

Resolves #348

Description of changes:

This PR will move the hardcoded tolerations from the DaemonSet template to the values, I just used the aws-fsx-csi-driver helm chart as inspiration. As this is probably the simplest solution, it may lead to unexpected changes if someone already has tolerations set.
I have added a new value: node.defaultTolerations and put it in the else condition in tolerateAllTaints.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jon-rei jon-rei requested a review from a team as a code owner January 21, 2025 15:38
@@ -35,6 +35,12 @@ node:
limits:
memory: 256Mi
tolerateAllTaints: false
tolerations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this change, if someone provides node.tolerations, it will override existing tolerations, which could be a breaking change I think. Imagine someone relies on default tolerations provided by the CSI Driver and with this change they will go away. Not sure how big is a deal this, one alternative could be creating a new variable like node.defaultTolerations for these tolerations, but then one would need to override two Helm values to tweak this configuration.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was also something I was thinking about.

I guess for now, creating a new value is probably the best solution without introducing a breaking change. I have now added node.defaultTolerations and put it in the else condition in tolerateAllTaints. For me this is the simplest solution after playing around with helm templating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional taints conflict with default taints and cause constant restarts
2 participants