Allow overriding of hardcoded DaemonSet tolerations #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #348
Description of changes:
This PR will move the hardcoded tolerations from the DaemonSet template to the values,
I just used the aws-fsx-csi-driver helm chart as inspiration. As this is probably the simplest solution, it may lead to unexpected changes if someone already hastolerations
set.I have added a new value:
node.defaultTolerations
and put it in theelse
condition intolerateAllTaints
.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.