Add volumecontext package for accessing volume context from CSI
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
previously approved these changes
Jan 14, 2025
| @@ -96,7 +89,7 @@ func (c *CredentialProvider) Provide(ctx context.Context, volumeID string, volum | |||
| return nil, status.Error(codes.InvalidArgument, "Missing volume context") | |||
| } | |||
|
|
|||
| authenticationSource := volumeContext[VolumeCtxAuthenticationSource] | |||
| authenticationSource := volumeContext[volumecontext.AuthenticationSource] | |||
There was a problem hiding this comment.
Not blocking: The only difference here being capitalisation makes this more challenging to read at first glance.
There was a problem hiding this comment.
I can rename variables to volumeCtx, to have similar naming convention to built-in context package and ctx variable used widely.
There was a problem hiding this comment.
Addressed with 5da88fc
Signed-off-by: Burak Varlı <[email protected]>
This is to have same naming convention with built-in `context` package and `ctx` variable name used widely. Updated with `sg --pattern 'volumeContext' --rewrite 'volumeCtx' --lang go`. Signed-off-by: Burak Varlı <[email protected]>
unexge
force-pushed
the
unexge/add-volumectx-package
branch
from
cb6e302 to
5da88fc
Compare
muddyfish
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitted out of #328.
This might not make sense since it's moved out of its original context, but the original motivation was that these constants was spread out to different packages and that was causing circular dependencies.
For example, if you need to use
VolumeCtxBucketNameinpkg/driver/node/mounterpackage, you'd need to importpkg/driver/nodepackage which would cause a circular dependency aspkg/driver/nodeimportspkg/driver/node/mounter. In situations like that, it's best to extract common things into a leaf package that doesn't import anything, which is what this PR does withpkg/driver/node/volumecontextpackage.It also makes finding these volume context keys easier by placing them into a singular place.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.