Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip rsa8192.badssl.com Test to Fix CI #635

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Skip rsa8192.badssl.com Test to Fix CI #635

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7356c08
skip bad test
waahm7 Apr 1, 2024
470769f
unused warning fix
waahm7 Apr 1, 2024
0fc94d2
Fix comment
waahm7 Apr 1, 2024
ecf2f82
Return AWS_OP_SUCCESS. Skip still counts as failure.
waahm7 Apr 2, 2024
2bcff65
another warning fix
waahm7 Apr 2, 2024
ba77633
Skip in cmake
waahm7 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,13 @@ if(NOT BYO_CRYPTO)
# Badssl - Secure uncommon suite
# We skip 10000san for now as its unclear the point or relevance especially with respect to the OS-based
# TLS implementations
# We skip 1000san, sha384 and sha512 because the public badssl certificate is expired and we haven't migrated to
# We skip 1000san, sha384, rsa8192 and sha512 because the public badssl certificate is expired and we haven't migrated to
# internal hosting yet
# We also defer the incomplete chain test for now until we can do some further study on how to get it to
# properly fail on windows and osx.
# add_net_test_case(tls_client_channel_negotiation_success_sha384)
# add_net_test_case(tls_client_channel_negotiation_success_sha512)
add_net_test_case(tls_client_channel_negotiation_success_rsa8192)
# add_net_test_case(tls_client_channel_negotiation_success_rsa8192)
add_net_test_case(tls_client_channel_negotiation_error_no_subject)
add_net_test_case(tls_client_channel_negotiation_success_no_verify_no_subject)
add_net_test_case(tls_client_channel_negotiation_error_no_common_name)
Expand Down