Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version check CI #1167

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Version check CI #1167

merged 2 commits into from
Apr 25, 2024

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Adding a new job that will flag if a PR getting merged into master does not have version updated.

Why was it changed?

  • To ensure the CMake file is being changed before cutting a new release.
  • To also ensure no changes get merged to master unless a new version is being released.

How was it changed?

  • Added a new yml file to grep the cmake file for version.

What testing was done for the changes?

  • Tested with develop branch to confirm it works fine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@disa6302 disa6302 marked this pull request as ready for review April 25, 2024 19:16
@disa6302 disa6302 merged commit 81a294e into develop Apr 25, 2024
16 checks passed
@sirknightj sirknightj deleted the version-check-ci branch April 25, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefankiesz stefankiesz stefankiesz approved these changes

@niyatim23 niyatim23 niyatim23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@disa6302 @niyatim23 @stefankiesz