Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR description lint #1143

Closed
wants to merge 1 commit into from
Closed

Add PR description lint #1143

wants to merge 1 commit into from

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Add PR template check to CI and a PR template for this repo.

Why was it changed?

  • To ensure that every PR that is opened has a clear description of the changes.

How was it changed?

  • Created a PR template
  • Created a CI job to run the description checker
  • This PR needs to be targeted for merge in mainline since github does not pull in these changes from a non-mainline branch.

What testing was done for the changes?

  • The same template exists in WebRTC SDK which has been working fine for the past few months.
  • CI job in this PR to verify this description.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de4299f) 16.23% compared to head (2eab2c0) 16.23%.

❗ Current head 2eab2c0 differs from pull request most recent head 942204c. Consider uploading reports for the commit 942204c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   16.23%   16.23%           
=======================================
  Files          51       51           
  Lines        6892     6892           
=======================================
  Hits         1119     1119           
  Misses       5773     5773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Define minimum character count for each section
MIN_CHARS=25

# Extract contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate comment

@disa6302 disa6302 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants