-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support putFragmentMetadata from kvssink #1122
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1122 +/- ##
===========================================
- Coverage 16.48% 16.27% -0.22%
===========================================
Files 50 50
Lines 7019 7092 +73
===========================================
- Hits 1157 1154 -3
- Misses 5862 5938 +76 ☔ View full report in Codecov by Sentry. |
1a21a82
to
9a957ca
Compare
fe817db
to
9267a1a
Compare
9267a1a
to
998de7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue #, if available:
#1031
What was changed?
Modify
kvssink
and sample application to support adding metadata per fragmentWhy was it changed?
This feature was missing from
kvssink
and was requested by multiple customersHow was it changed?
put-metadata
every 2 seconds. This application-level logic can be customized by the customers to be fired on their own set of events / frequency.put-metadata
can be modified by the customers to generate metadata tags to be put. Currently, they consume values from a global instance of CustomData whose counter is updated withinput-metadata
itself.put-metadata
also callsput-fragment-metadata
put-fragment-metadata
generates theGstStructure
expected by theGST_EVENT_CUSTOM_DOWNSTREAM
and ultimately triggers theGST_EVENT_CUSTOM_DOWNSTREAM
that handles the tags and calls the underlying KVS APIputFragmentMetadata
.What testing was done for the changes?
Tested the following locally:
mkvinfo
persistent
is indeed persisted for each fragment of the videonon-persistent
is not persisted for each fragment of the videopersistent
andnon-persistent
and the both of them are marked correctly in the videomkvinfo
on a video dump from the tests (even metadata-keys are persistent, odd ones are non-persistent): mkvinfo-metadata.txtBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.