Fix KVSSINK State Transition Deadlock #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1102 +/- ##
===========================================
+ Coverage 16.34% 16.38% +0.04%
===========================================
Files 51 51
Lines 6846 6852 +6
===========================================
+ Hits 1119 1123 +4
- Misses 5727 5729 +2
☔ View full report in Codecov by Sentry. |
* Update ci.yml compiler env var * Add refreshenv to windows build * Add import module for refreshenv call * Testing * Revert windows CI changes * Update ci.yml * Trying different PKG_CONFIG_EXECUTABLE path * Add msvc_ to path * More build testing * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * works, testing which line(s) is needed * more * more * Cleanup ci * cleanup cmake * Update README.md * Add check for C vs D drive * Revert ReadMe changes
* Update ci.yml compiler env var * Add refreshenv to windows build * Add import module for refreshenv call * Testing * Revert windows CI changes * Update ci.yml * Trying different PKG_CONFIG_EXECUTABLE path * Add msvc_ to path * More build testing * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * more * works, testing which line(s) is needed * more * more * Cleanup ci * cleanup cmake * Update README.md * Add check for C vs D drive * Revert ReadMe changes
* m1 build * fix indentation * make once * cmake update * add tests to m1 build * change producer c git_tag to develop * fix mac clang
…/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp into fix-kvssink-pipeline-transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move parent state transition to be in between upward and downward element transitions as per GStreamer documentation.
Tested using
kvssink_gstreamer_sampleto successfully ingest stream and cleanly exit upon sigint with videotestsrc, filesrc, and rtspsrc sources.