Fix disk usage data discrepancy on Darwin #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in scraping disk usage on macOS systems. The problem stems from gopsutil's reliance on
unix.Statfs
, which is not accurately retrieving disk usage data on macOS. Whileunix.Statfs
is generally reliable on many Unix systems, it seems to be incompatible with macOS's specific filesystem (APFS) implementation or reporting mechanisms. This leads to inaccurate disk usage metrics (where all reported mount points have same used space values), impacting macOS customers' observability to their resources.Why
df
and notdiskutil
?df
is preferred due to its universality across unix-like systems including Darwin and consistent/simple output format. Whilediskutil
offers more detailed macOS-specific information, its limited platform support and potential for format changes make it less suitable.Changes:
darwin
from os build target indisk_unix
which contains a function to retrieve disk usageUsageWithContext
indisk_darwin
usingdf
Tested on
mac1.metal
test instance: (screenshot showing all mount points reporting identical values fordisk_used
metric then showing correct values with this fix)