Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cw): Enhance UX for Q chat #6611

Open
wants to merge 24 commits into
base: feature/falcon
Choose a base branch
from
Open

feat(cw): Enhance UX for Q chat #6611

wants to merge 24 commits into from
+1,013 −46

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Feb 18, 2025

Problem

The Q chat experience needs improvement.

Solution

  1. Enabling prompt templates in chat window.
  2. Allow user to explicit select file or folder selector in the chat window as context.
  3. Improve context transparency, show user what context was used in the chat response.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners February 18, 2025 19:06
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@andrewyuq andrewyuq requested review from a team as code owners February 18, 2025 19:41
leigaol
leigaol commented Feb 19, 2025
View reviewed changes
src.gen/@amzn/codewhisperer-streaming/src/models/models_0.ts
@@ -1019,6 +1019,8 @@ export interface RelevantTextDocument {
* @public
*/
documentSymbols?: (DocumentSymbol)[] | undefined;
startLine?: number;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving these out from src.gen because code in src.gen are supposed to be auto generated. Next time it updates, these 2 fields will be gone

@leigaol leigaol force-pushed the internal_falcon_release branch from 174148b to e2354da Compare February 19, 2025 20:13
@avi-alpert avi-alpert force-pushed the internal_falcon_release branch from a0681aa to 3dca459 Compare February 19, 2025 21:07
leigaol and others added 18 commits February 19, 2025 16:11
@leigaol @avi-alpert
feat(amazonq): add context command selection to Q chat (#5)
3016616 
* local ws working

* beta_2

* rename

* update

* code format

* apply context cmd to all tabs

* context to the api call

* minimize changes

* update

* update

* format code

* update to lsp

* update context commands

* update context commands

* clean up

* beta5

* update

* use lsp to resolve additionalContext
@leigaol @avi-alpert
fix cyclic dependencies; minimize code changes; reformat code
db88beb
@leigaol @avi-alpert
further fix cyclic dependency
6c6e284
@leigaol @avi-alpert
update lsp for falcon (#6)
9e94095
@leigaol @avi-alpert
fix minor bug when context cmd list is empty
2726c7a
@avi-alpert
feat(amazonq): saved prompts (#7)
79e531b 
* feat(amazonq): saved prompts

* fix: remove unecessary change
@avi-alpert
Add 'create a new prompt' context to bottom of prompts list (#8)
e2b54e8 
* feat(amazonq): saved prompts

* fix: remove unecessary change

* feat(amazonq): saved prompts

* fix: remove unecessary change

* feat(amazonq): add Create a new prompt button to context
@leigaol @avi-alpert
dev lsp 0.1.37
450d789
@andrewyuq @avi-alpert
Add context transparency feature to Q chat @workspace (#9)
a082f07 
* Add context transparency feature to Q chat @workspace

* remove console log

* remove console log

* remove unused FileClickMessage
@avi-alpert
fix: add fs exists check for system prompts directory (#10)
4315618 
* feat(amazonq): saved prompts

* fix: remove unecessary change

* feat(amazonq): saved prompts

* fix: remove unecessary change

* fix: add fs exists check for ~/.aws/prompts

* fix: whitespace
@avi-alpert
fix: @workspace command (#11)
d0af6fe 
* fix: @workspace command

* remove first instance of workspace from message
@leigaol @avi-alpert
speed up loading the context commands (#12)
98078fe
@leigaol @avi-alpert
update lsp version
6ef5f35
@avi-alpert
fix: add feature flag command to context (#13)
7bcbaf1 
* fix: add feature flag command to context

* fix: move into additional commands
@leigaol @avi-alpert
lsp version to 0.1.39
023c57a
@leigaol @avi-alpert
fix linter
276111e
@avi-alpert
fix: refresh prompt list when project prompt is added (#16)
65d657c 
* fix: refresh prompt list when project prompt is added

* fix: validate length and size of additionalContents

* fix: truncate additionalContents based on api validation limits

* fix: move constants
@andrewyuq @avi-alpert
context transparency multiple fixes (#17)
fbd40c8 
* context transparency multiple fixes

1. add manually selected context from prompt into context list
2. fix -1 start/end line edge cases
3. Center selction after clicking on the file

* remove console.log
@avi-alpert avi-alpert force-pushed the internal_falcon_release branch from 3dca459 to fbd40c8 Compare February 19, 2025 21:12
leigaol and others added 4 commits February 19, 2025 15:13
@leigaol
promot version to 1.49.0
7d80fd3
@andrewyuq
fix no context without @workspace but with explicit mention (#21)
aef0524
@avi-alpert
fix: clicking on workspace prompt files in context transparency (#22)
b030acf
@avi-alpert
feat: add automatic workspace rules and fix clicking on user prompt (#23
8c41430 
)

* feat: add automatic workspace rules and fix clicking on user prompt in context transparency

* add comments to code

* fix: display os specific path in create prompt dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avi-alpert avi-alpert avi-alpert left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leigaol @avi-alpert @andrewyuq