Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DescribeSecret cache #22

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

simonmarty
Copy link
Contributor

@simonmarty simonmarty commented Jul 19, 2024

Issue #, if available: Closes #20

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simonmarty simonmarty changed the title Add DescribeSecret cache. Add DescribeSecret cache Jul 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 23.97661% with 130 lines in your changes missing coverage. Please review.

Project coverage is 66.59%. Comparing base (994fe63) to head (5f1a161).

Files Patch % Lines
...nager_caching/src/output/describe_secret_output.rs 0.00% 89 Missing ⚠️
...nager_caching/src/secret_store/memory_store/mod.rs 4.54% 21 Missing ⚠️
aws_secretsmanager_caching/src/lib.rs 60.78% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   69.03%   66.59%   -2.44%     
==========================================
  Files          13       14       +1     
  Lines        2842     2967     +125     
  Branches       10        9       -1     
==========================================
+ Hits         1962     1976      +14     
- Misses        880      991     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DescribeSecret cache to aws_secretsmanager_caching
2 participants