-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…33678) ### Issue # (if applicable) n/a ### Reason for this change The `awslint` rules enforce naming to be consistent with CloudFormation resources. In this case, the CFN resource is `AWS::Scheduler::ScheduleGroup` but the construct was named `Group` when it should be `ScheduleGroup`. When this module is stabilized, `Group` will be completely removed. ### Description of changes - Mark `Group` and related methods as deprecated. Deprecation - Introduce new class `ScheduleGroup` (duplicate of Group, just renamed) - Addressed most `awslint` exemptions in the module - Update any logic referencing `group` to reference `scheduleGroup` - Updated README examples ### Describe any new or updated permissions being added n/a ### Description of how you validated changes Updated unit tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
12 changed files
with
826 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,10 @@ | ||
{ | ||
"exclude": [ | ||
"construct-ctor-props-optional:@aws-cdk/aws-scheduler-alpha.Group", | ||
"props-physical-name:@aws-cdk/aws-scheduler-alpha.GroupProps", | ||
"from-method:@aws-cdk/aws-scheduler-alpha.Schedule", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleArn", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleName", | ||
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleGroup", | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.ContextAttribute.name", | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.Group", | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.GroupProps", | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.IGroup", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleProps.targetOverrides", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.deadLetterConfig", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.ecsParameters", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.eventBridgeParameters", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.input", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.kinesisParameters", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.retryPolicy", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.sageMakerPipelineParameters", | ||
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.sqsParameters", | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.ScheduleTargetProps" | ||
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.IGroup" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.