Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.3 #503

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Release 1.6.3 #503

merged 7 commits into from
Dec 17, 2024

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Dec 13, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

sushrk and others added 6 commits December 13, 2024 23:04
* Add flags to configure controller parameters

* update flag names
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.19.0 to 2.22.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.0...v2.22.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump k8s.io/apimachinery from 0.30.2 to 0.31.1

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.30.2 to 0.31.1.
- [Commits](kubernetes/apimachinery@v0.30.2...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* upgrading client-go, controller-runtime versions too

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/aws/amazon-vpc-cni-k8s from 1.18.1 to 1.18.3

Bumps [github.com/aws/amazon-vpc-cni-k8s](https://github.com/aws/amazon-vpc-cni-k8s) from 1.18.1 to 1.18.3.
- [Release notes](https://github.com/aws/amazon-vpc-cni-k8s/releases)
- [Changelog](https://github.com/aws/amazon-vpc-cni-k8s/blob/v1.18.3/CHANGELOG.md)
- [Commits](aws/amazon-vpc-cni-k8s@v1.18.1...v1.18.3)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-cni-k8s
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* update decoder type to fix presubmit failures

* update auto-generated CRD file

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: sushrk <[email protected]>
@yash97 yash97 requested a review from a team as a code owner December 13, 2024 23:28
@haouc
Copy link
Contributor

haouc commented Dec 13, 2024

Let's hold on this before we have sync on this PR: 53939cd

My concern is on managed -> unmanaged Update workflow.

Update: synced offline. Tests sounds good to me.

@sushrk
Copy link
Contributor

sushrk commented Dec 14, 2024

Let's hold on this before we have sync on this PR: 53939cd

My concern is on managed -> unmanaged Update workflow.

Synced on this offline, VPC-CNI does not remove the feature from CNINode on disabling the feature, hence node is not updated as being unmanaged-

[13/12/24 4:13:20] ➜  ~ kubectl set env daemonset aws-node -n kube-system ENABLE_POD_ENI=false                                       
daemonset.apps/aws-node env updated
[13/12/24 4:16:17] ➜  ~ kubectl get cninodes                                                  
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal     [{"name":"SecurityGroupsForPods"}]

I restarted one instance on EC2 console, and the feature is removed only for that particular node and it is marked as an unmanaged node:

[13/12/24 4:21:10] ➜  ~ kubectl get cninodes           
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal     

Also tested with aws-node restarts and verified the feature is not removed(the last node is the same restarted node form above):

[13/12/24 4:21:31] ➜  ~ kubectl rollout restart ds -n kube-system aws-node                     
daemonset.apps/aws-node restarted
[13/12/24 4:28:07] ➜  ~ kubectl get cninodes                              
NAME                                            FEATURES
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal   [{"name":"SecurityGroupsForPods"}]
ip-xxxx.us-west-2.compute.internal     

haouc
haouc previously approved these changes Dec 14, 2024
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@yash97 yash97 merged commit 2c6894c into aws:release-1.6 Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants