Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNINode to cache filter #3164

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

dims
Copy link
Member

@dims dims commented Dec 31, 2024

We should reduce the number of CNINode object VPC CNI watches for to just the node it is managing as well.

What type of PR is this?
improvement

Which issue does this PR fix?:

Please see #3158

Very similar to #2887 and #2888 but this one is to limit CNINode's

What does this PR do / Why do we need it?:

This PR adds a filter to reduce the number of CNINode object VPC CNI watches for to just the node it is managing.

Testing done on this change:

EKS scalability clusters by @hakuna-matatah

No.

Will this PR introduce any new dependencies?:

No.

Will this break upgrades or downgrades? Has updating a running cluster been tested?:

No.

Does this change require updates to the CNI daemonset config files to work?:

No.

Does this PR introduce any user-facing change?:

No.

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dims dims requested a review from a team as a code owner December 31, 2024 16:23
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dims

We should reduce the number of CNINode object VPC CNI watches for to
just the node it is managing as well.

Signed-off-by: Davanum Srinivas <[email protected]>
Co-Authored-By: Hao Zhou <[email protected]>
Co-Authored-By: Harish Kuna <[email protected]>
@dims dims force-pushed the add-CNINode-to-cache-filter branch from 6b38997 to 874114a Compare January 4, 2025 12:35
@jayanthvn jayanthvn merged commit f4b0a78 into aws:master Jan 5, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants