Fix Assemble Tableau Connector GHA
#249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryn5
force-pushed
the
ryan/taco-failure
branch
from
1d8db5e to
791e8c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #249 +/- ##
========================================
Coverage 67.40% 67.40%
========================================
Files 122 122
Lines 5882 5882
Branches 585 585
========================================
Hits 3965 3965
Misses 1566 1566
Partials 351 351 ☔ View full report in Codecov by Sentry. |
ryn5
force-pushed
the
ryan/taco-failure
branch
4 times, most recently
from
148bd75 to
0d7fffe
Compare
ryn5
changed the title
Assemble Tableau Connector GHAAssemble Tableau Connector GHA
kenhuuu
reviewed
Jan 24, 2024
ryn5
force-pushed
the
ryan/taco-failure
branch
from
0d7fffe to
7009237
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Assemble Tableau Connector workflow has been failing when attempting to append versioning to the filename. This is caused by two points of failure:
The taco inherits versioning from manifest.xml when being built before assembly.
build.shattempts to copyneptune-jdbc.tacorather thanneptune-jdbc-v3.0.2.taco, causing a failure to copy the taco into TARGET_FOLDER.The Assemble Tableau Connector workflow redundantly attempts to rename the taco with versioning, causing it to fail since
neptune-jdbc.tacodoesn't exist to be renamed.Description
Related Issue
Additional Reviewers