Add assertions and type safety after #61 #69
Conversation
Also fix mistyped return annotation on `resolveGraphDBQuery`, my bad
| @@ -9,7 +9,5 @@ | |||
| "--create-update-aws-pipeline-neptune-endpoint", "<AIR_ROUTES_DB_HOST>:<AIR_ROUTES_DB_PORT>", | |||
| "--output-resolver-query-https"], | |||
| "host": "<AIR_ROUTES_DB_HOST>", | |||
| "port": "<AIR_ROUTES_DB_PORT>", | |||
| "testOutputFilesSize": ["output.resolver.graphql.js", "output.schema.graphql", "output.source.schema.graphql"], | |||
There was a problem hiding this comment.
Since you're cleaning up test files with unused fields can you also do the same for Case03/case.json?
| @@ -27,12 +28,17 @@ const schema = buildASTSchema(schemaDataModel, { assumeValidSDL: true }); | |||
| export function resolveGraphDBQueryFromAppSyncEvent(event) { | |||
| const fieldDef = getFieldDef(event.field); | |||
|
|
|||
| assert(fieldDef); | |||
There was a problem hiding this comment.
For troubleshooting would be nice to add a value for the optional message parameter to indicate what expected state was not satisfied ie. Field definition for ${event.field} not found.
| const value = event.arguments[inputDef.name.value]; | ||
|
|
||
| if (value) { | ||
| const inputType = typeFromAST(schema, inputDef.type); | ||
|
|
||
| assert(isInputType(inputType)); |
There was a problem hiding this comment.
For troubleshooting would be nice to add a value for the optional message parameter to indicate what expected state was not satisfied ie. Type ${inputType} is not a valid input type.
| for (const rootDef of rootTypeDefs) { | ||
| const fieldDef = rootDef.fields.find(def => def.name.value === fieldName); | ||
| for (const rootTypeDef of rootTypeDefs) { | ||
| const fieldDef = rootTypeDef.fields?.find(def => def.name.value === fieldName); |
There was a problem hiding this comment.
Perhaps the Case03 which is not currently asserting any validation after the utility is executed can be repurposed to verify error handling for scenarios addressed in this PR (app sync event fields do not match up with the graphQL schema). This could be done by using similar approach to your Case01.05.test.js tests except modifying the app sync event to reference unknown types.
Issue #, if available: relates to #61 (see #61 (comment))
Description of changes:
Also fix mistyped return annotation on
resolveGraphDBQuery, my badBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.