Add New Metrics For Where Customer Are Using The Agent #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
commented
Oct 17, 2023
translator/util/sdkutil.go
Outdated
| region = SDKRegionWithCredsMap(mode, credsConfig) | ||
| regionType = agentinfo.REGION_NOT_FOUND |
There was a problem hiding this comment.
I think if this happens, the agent will shut down before being able to reach out to the backend to send this metric. I will leave this in any way.
sethAmazon
force-pushed
the
new-metrics
branch
from
6e715ec to
6781fb3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 57.58% 62.95% +5.37%
==========================================
Files 370 325 -45
Lines 17548 16154 -1394
==========================================
+ Hits 10105 10170 +65
+ Misses 6848 5470 -1378
+ Partials 595 514 -81
☔ View full report in Codecov by Sentry. |
sethAmazon
force-pushed
the
new-metrics
branch
from
6781fb3 to
bf65482
Compare
|
We may need to increase our header size so we do not drop logs since we are increasing the header size with this change. |
sethAmazon
force-pushed
the
new-metrics
branch
2 times, most recently
from
c38a9b1 to
3fbfdec
Compare
sethAmazon
commented
Oct 18, 2023
| @@ -31,7 +31,7 @@ const ( | |||
| LogEntryField = "value" | |||
|
|
|||
| defaultFlushTimeout = 5 * time.Second | |||
| eventHeaderSize = 26 | |||
| eventHeaderSize = 200 | |||
There was a problem hiding this comment.
Changed to 200 at the request of @bryce-carey
jefchien
reviewed
Oct 23, 2023
| @@ -96,6 +97,17 @@ func (ctx *Context) Mode() string { | |||
| return ctx.mode | |||
| } | |||
|
|
|||
| func (ctx *Context) ShortMode() string { | |||
There was a problem hiding this comment.
Spoke offline changed to suggestions
sethAmazon
force-pushed
the
new-metrics
branch
3 times, most recently
from
5f187b5 to
747f0f0
Compare
sethAmazon
force-pushed
the
new-metrics
branch
from
747f0f0 to
713f5e9
Compare
jefchien
approved these changes
Oct 23, 2023
bryce-carey
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
CloudWatch Agent wants to collect metrics on where the agent is being run.
Description of changes
Add metrics for CloudWatch Agent mode and region provider. I did this by creating global variables for these metrics and shoving them into the config layer to be picked up by the plugins. This is because this information is only known at translation time, but we need this information at plugin runtime.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit tests
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint