Bug fix for duplicate log events by resetting the response body stream in agent health #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m in agent health
dchappa
approved these changes
Sep 5, 2024
zhihonl
approved these changes
Sep 5, 2024
jefchien
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
cloudwatchlogs tests are passing again https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10722781289/job/29734778829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Duplicate log events are being published for all use-cases. This was determined to be due to the reading of the HTTP response body in the agent health extension. The body is being read elsewhere, but can only be read once. We reset the body to address the issue.
Description of changes
Resets the response body stream with the content that was read.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Manually tested to confirm that the log events are no longer duplicated.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint