Add full support for ECS in Application Signals #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
force-pushed
the
ecs
branch
3 times, most recently
from
b732753 to
ec93040
Compare
jefchien
reviewed
Sep 9, 2024
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer.go
Outdated
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer.go
Outdated
Show resolved
Hide resolved
translator/tocwconfig/sampleConfig/appsignals_and_eks_config.yaml
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/resourcedetection/configs/config.yaml
Outdated
Show resolved
Hide resolved
bjrara
force-pushed
the
ecs
branch
3 times, most recently
from
5b4cf0e to
c5e73ec
Compare
sky333999
reviewed
Sep 10, 2024
translator/translate/otel/processor/resourcedetection/configs/ecs_config.yaml
Show resolved
Hide resolved
translator/translate/otel/processor/resourcedetection/configs/ecs_config.yaml
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/resolver/ecs.go
Outdated
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/resolver/attributesresolver.go
Show resolved
Hide resolved
|
I was expecting to see |
EMF template is shared across non EKS/K8s platforms, it reuses the generic one. |
bjrara
force-pushed
the
ecs
branch
2 times, most recently
from
b0550c4 to
f30ed6f
Compare
|
This PR was marked stale due to lack of activity. |
bjrara
force-pushed
the
ecs
branch
3 times, most recently
from
967c2cd to
db411c3
Compare
bjrara
changed the title
jefchien
approved these changes
Sep 27, 2024
sky333999
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently, traffic from ECS is recognized as from generic platform. This PR adds ECS as a supported platform, and includes more ECS specific attributes in the Application Signals EMF log.
In addition, it removes resource detection for Task related attributes, and relies on client side to provide the accurate values. This is mainly to support deploying CloudWatch agent as Daemon or a standalone service on an ECS Cluster.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added unit tests.
Integration tests
https://github.com/aws-observability/aws-application-signals-test-framework/actions/workflows/python-ecs-canary.yml
https://github.com/aws-observability/aws-application-signals-test-framework/actions/workflows/java-ecs-canary.yml
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint