Support for v2.9.2, v2.10.1, and v2.10.3 and paging support for large metadata #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr_factory.py: Filters backup_metadata to ensure the scheduler does not resume backup_metadata with the status running during batch imports of metadata. If the scheduler resumes, it will overwrite the metadata while the import is running.
test_dr_factory_2_4.py: Add expected_export_filters to the tests.
test_base_table.py:
Adjust tests to assert that copy_expert is called with StringIO("".join(batch)).
Add test_restore_batch_size to ensure that commit is called twice when the file contains more rows than the batch size.
…store_more_than_batch_size and test_restore_cursor_exception
… itertools.islice for yielding lines instead of looping over the lines of the file. Thank you for the recommendation!
…sor/paging to reduce the memory pressure. Fixing broken test cases.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This was referenced Feb 14, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR makes following contribution:
Related Tickets & Documents
Linting
Have you done linting by issuing
./build.sh lintcommand?Testing
Have you run testing by issuing
./build.sh unitcommand?Documentation
Have you updated the README appropriate for this PR?
Changelog
Have you updated the CHANGELOG with the changes you are making in this PR?
Please use Added, Removed, and/or Changed subsections under the Unreleased section.
Terms of Contribution
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.