refactor: improve build scripts #23
Conversation
templates/python/build.sh
Outdated
|
|
||
| python_templates=$(ls -d */ | sed 's/\//\n/g') | ||
| current_directory=`pwd` | ||
| for template in $maven_templates; do | ||
| cd $current_directory/$template | ||
| echo "Building $template template" | ||
| done |
There was a problem hiding this comment.
Why do we need this at all?
There was a problem hiding this comment.
It is not doing anything other than looping over the folders we can add the commands to build the python templates in there so we check everything can be built
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| maven_templates='HelloWorld' | |||
| maven_templates=$(ls -d */ | sed 's/\//\n/g') | |||
There was a problem hiding this comment.
Nit: This change assumes that all the templates inside Java can be built with maven. This will have to be modified if things change and that is also fine.
There was a problem hiding this comment.
Correct the current one is assuming the same. This is just improving it so we don't have to add the names of the folders every time we add a new template
There was a problem hiding this comment.
On the other hand, wondering is we should build these with gdk commands as that's we expect.
There was a problem hiding this comment.
Mmmm definitely gdk commands I think.
There was a problem hiding this comment.
I will hold off on trying to do this. Right now the gdk does not allow you to specify the path to the artifact and for the OTF framework it is inside one of the submodules
templates/python/build.sh
Outdated
| python_templates=$(ls -d */ | sed 's/\//\n/g') | ||
| current_directory=`pwd` | ||
| for template in $maven_templates; do |
There was a problem hiding this comment.
should be python_templates if we still wanna keep it.
Description of changes:
Changes the build script so that new template names do not need to be added and get automatically build by the build script.
Why is this change necessary:
Dev don't have to remember about adding the new template folder name to the build script