fix: Pin Ubuntu image to allow link checker action to run #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR pins the the Ubuntu image used by the
check_for_broken_linksworkflow to 22.04.Currently, the workflow is failing due to using
ubuntu-latestwhich has tightened its access to the user namespaces kernel feature. Chromium is no longer able to run with this new security feature in place as it currently requires it. (See: https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md) As it relates to this repo, we use Puppeteer with headless Chromium to drive link checking and, as of a few weeks ago, this workflow has been failing since GH Actions have been slowly rolling out version 24 as the newubuntu-latestover 22.Per the recommendations in this GitHub issue, pinning the Ubuntu image used by this workflow to 22.04 is a popular workaround and should unblock this workflow. (See test run conducted against a feature branch: https://github.com/aws-amplify/docs/actions/runs/13188025380/job/36814728240?pr=8241)
In the meantime, we can continue to explore other alternatives for a longer term solution (e.g. disabling the unprivileged user restriction - which other repos, including Puppeteer - has done, or introducing an AppAmor profile)
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.