Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-data): callout extend type support limitation #8221

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Jan 27, 2025

Description of changes:

This update clarifies a limitation regarding the use of the 'extend' keyword in GraphQL type definitions with Amplify directives.

Changes

Updated documentation to explicitly state the restriction on using Amplify directives with extended type definitions
Clarified that 'extend' keyword is supported only for Queries, Mutations, and Subscriptions

Reason

Provide clear guidance to developers about the current limitations of extending GraphQL types with Amplify directives.

Impact

Developers will have a better understanding of the constraints when working with extended type definitions in Amplify.

image

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from josefaidt as a code owner January 27, 2025 22:42
@sundersc sundersc enabled auto-merge (squash) January 28, 2025 18:44
@sundersc sundersc merged commit 4a15939 into aws-amplify:main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants