Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass props from withAuthenticator to Component #840

Merged
merged 5 commits into from
Nov 23, 2021

Conversation

ericclemmons
Copy link
Contributor

Issue #, if available: Closes #837

Description of changes:

withAuthenticator didn't pass along props, but this PR passes it & validates it with a new .feature test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2021

🦋 Changeset detected

Latest commit: 1889755

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ericclemmons ericclemmons self-assigned this Nov 22, 2021
@ericclemmons ericclemmons added Authenticator An issue or a feature-request for an Authenticator UI Component React An issue or a feature-request for React platform labels Nov 22, 2021
@ericclemmons ericclemmons temporarily deployed to ci November 22, 2021 23:35 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 22, 2021 23:35 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 22, 2021 23:35 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 22, 2021 23:54 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 23, 2021 00:04 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 23, 2021 00:04 Inactive
@ericclemmons ericclemmons temporarily deployed to ci November 23, 2021 00:04 Inactive
@ericclemmons ericclemmons enabled auto-merge (squash) November 23, 2021 00:16
@ericclemmons ericclemmons temporarily deployed to ci November 23, 2021 00:23 Inactive
@ericclemmons ericclemmons merged commit 5522af0 into main Nov 23, 2021
@ericclemmons ericclemmons deleted the 837-withAuthenticator-props branch November 23, 2021 00:28
@github-actions github-actions bot mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component React An issue or a feature-request for React platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use withAuthenticator HOC with Next.js
2 participants