Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changesets): add react-native-example to ignoreList #3351

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Jan 26, 2023

Description of changes

Adding react-native-example to changesets ignore list. This ensures that it'll not show up when you run yarn changeset.

With this change, only public NPM packages will show up through changesets CLI:

image

Note that if you add changesets through the Changesets GitHub App, this PR still won't prevent it from automatically including private packages. I created an issue on their end: changesets/bot#44.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wlee221 wlee221 requested a review from a team as a code owner January 26, 2023 00:42
@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

⚠️ No Changeset found

Latest commit: 689dfa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"vue-example",
"amplify-ui-angular-mono",
"e2e"
"react-native-example",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized while I was here, but the change here is just adding "react-native-example".

Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@wlee221 wlee221 enabled auto-merge (squash) January 26, 2023 00:59
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 00:59 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 00:59 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 00:59 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 01:11 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 01:11 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 01:11 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 07:12 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 07:12 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 07:12 — with GitHub Actions Inactive
@wlee221 wlee221 temporarily deployed to ci January 26, 2023 07:12 — with GitHub Actions Inactive
@wlee221 wlee221 merged commit 00f085a into main Jan 26, 2023
@wlee221 wlee221 deleted the ignore-rn-example branch January 26, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants