Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auth): properly redacting session information #3472

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix(Auth): properly redacting session information #3472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54c5b7
fix(Auth): properly redacting session information
harsh62 Jan 15, 2024
2f55d10
missing a bracket
harsh62 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Task/Protocols/AmplifyAuthTask.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ extension AmplifyAuthTask where Self: DefaultLogger {
do {
log.info("Starting execution for \(eventName)")
let valueReturned = try await execute()
log.info("Successfully completed execution for \(eventName) with result:\n\(prettify(valueReturned))")
harsh62 marked this conversation as resolved.
Show resolved Hide resolved
log.info("Successfully completed execution for \(eventName) with result:\n\(valueReturned))")
dispatch(result: .success(valueReturned))
return valueReturned
} catch let error as Failure {
log.error("Failed execution for \(eventName) with error:\n\(prettify(error))")
log.error("Failed execution for \(eventName) with error:\n\(error)")
dispatch(result: .failure(error))
throw error
}
Expand All @@ -47,10 +47,4 @@ extension AmplifyAuthTask where Self: DefaultLogger {
let payload = HubPayload(eventName: eventName, context: nil, data: result)
Amplify.Hub.dispatch(to: channel, payload: payload)
}

private func prettify<T>(_ value: T) -> String {
var result = ""
dump(value, to: &result)
return result
}
}
Loading