Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use macos-13 runners for stress tests and use explicit iOS version #3310

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

atierian
Copy link
Member

@atierian atierian commented Oct 18, 2023

Description

Stress tests are failing because they're still running on macos-12 runners that don't have Xcode 14.3, which added the fulfillment(of:) API.

  • Updates stress tests to run on macos-13

It looks like tests are taking longer when using OS=latest for iOS test runs. Using an explicit version sped up the PushNotifications integration tests dramatically.

  • Specifies exact iOS version in integration tests (OS=16.4)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:30 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:31 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:31 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:31 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:31 — with GitHub Actions Inactive
@atierian atierian marked this pull request as ready for review October 18, 2023 22:45
@atierian atierian requested a review from a team as a code owner October 18, 2023 22:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #3310 (0703240) into main (aef39fd) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3310      +/-   ##
==========================================
+ Coverage   64.31%   64.51%   +0.19%     
==========================================
  Files        1075     1075              
  Lines       35887    35887              
==========================================
+ Hits        23080    23151      +71     
+ Misses      12807    12736      -71     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 66.15% <ø> (ø)
Amplify 47.84% <ø> (ø)
Analytics_plugin_unit_test 81.37% <ø> (ø)
Auth_plugin_unit_test 74.10% <ø> (+0.01%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.13% <ø> (+1.05%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.09% <ø> (ø)
Predictions_plugin_unit_test 37.29% <ø> (ø)
PushNotifications_plugin_unit_test 60.29% <ø> (ø)
Storage_plugin_unit_test 54.18% <ø> (ø)
unit_tests 64.51% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atierian atierian temporarily deployed to Fortify October 18, 2023 22:51 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:58 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:59 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:59 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:59 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:59 — with GitHub Actions Inactive
@atierian atierian temporarily deployed to IntegrationTest October 18, 2023 22:59 — with GitHub Actions Inactive
@atierian atierian merged commit 03e1b13 into main Oct 18, 2023
@atierian atierian deleted the macos-13-runners branch October 18, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants