Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify Preview Status not update in Github Action #3287

Closed
5 tasks done
jackykwandesign opened this issue Feb 2, 2023 · 6 comments
Closed
5 tasks done

Amplify Preview Status not update in Github Action #3287

jackykwandesign opened this issue Feb 2, 2023 · 6 comments
Assignees
Labels
archived This issue has been locked. question Further information is requested web-previews Related to preview branches

Comments

@jackykwandesign
Copy link

Before opening, please confirm:

  • I have checked to see if my question is addressed in the FAQ.
  • I have searched for duplicate or closed issues.
  • I have read the guide for submitting bug reports.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • I have removed any sensitive information from my code snippets and submission.

App Id

d9yldpv6pkjrw

AWS Region

ap-southeast-1

Amplify Hosting feature

Web previews

Describe the bug

same as #1458 (comment)

When multiple PR trigger build in Amplify, it will never update Github CICD status check,
stuck at building forever
image

But in AWS amplify console, it show finish status
image

Expected behavior

Github CICD status always show correct status, or we can trigger job rerun in github action

Reproduction steps

Trigger amplify preview with two branch running at the same time, so if job B start running when job A not finish yet, they will stuck forever

Build Settings

NA

Log output

# Put your logs below this line


Additional information

No response

@jackykwandesign jackykwandesign added bug Something isn't working pending-triage labels Feb 2, 2023
@ghost ghost added question Further information is requested bug Something isn't working and removed bug Something isn't working question Further information is requested labels Feb 3, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

Hi @jackykwandesign 👋🏽, thanks for raising this issue. We are working on reproducing this behavior and adding it to our product backlog for prioritization.

@Jay2113
Copy link
Contributor

Jay2113 commented Sep 7, 2023

Hi @jackykwandesign 👋 , thanks for raising this and apologies for the delayed response on this thread.

I was unable to reproduce the outlined behavior when implementing the following workflow:

  • Create a sample React app and commit the code to a git repository (main branch)
  • Enable PR previews against the main branch
  • Create 2 branches and commit the changes to the git repository:
    • dev
    • stage
  • Create a pull request for each branch against main in a short timeframe so that the PR builds are triggered simultaneously
  • Under the Previews section in the Amplify Console, a couple of branches were successfully created and deployed for these PRs:
    • pr-1
    • pr-2

Are you still experiencing this issue? If yes, can you please share your workflow with detailed steps so we can reproduce it on our end.

@Jay2113 Jay2113 added question Further information is requested web-previews Related to preview branches and removed bug Something isn't working pending-triage labels Sep 7, 2023
@alexilyaev
Copy link

We are experiencing this issue as well

Info

  • Region - US East (N. Virginia) us-east-1
  • App ARN - arn:aws:amplify:us-east-1:047210519766:apps/d8m0lyvg5mo6g

Our Setup

  • Monorepo with 1 of the packages being a React app with Storybook
  • Connected to main branch with environment variable AMPLIFY_DIFF_DEPLOY=true
  • Previews enabled for the main branch
  • Created a PR pr-1119 on 9/20/2023, 2:41:31 PM IDT
  • Preview build stopped after a couple of minutes because there were no changes to the appRoot
  • But the build on Amplify showed as still in progress until eventually failed after 20 minutes 42 seconds

image

  • During that time on the GitHub PR the step was in progress

image

  • Until eventually failed around the time the Amplify Build failed

So, in this case maybe the issue is that the Amplify build didn't terminate when it detected nothing else needs to be done

@Narrator
Copy link
Contributor

Narrator commented Mar 28, 2024

@jackykwandesign @alexilyaev We pushed a fix for this issue last week - AMPLIFY_DIFF_DEPLOY should now work as expected. Please re-open this issue if you continue to face issues.

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Copy link

This issue has been automatically locked.

@github-actions github-actions bot added the archived This issue has been locked. label Mar 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This issue has been locked. question Further information is requested web-previews Related to preview branches
Projects
None yet
Development

No branches or pull requests

4 participants