Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About preview functionality bugs which seems have been fixed #3405

Open
4 tasks done
clichedmoog opened this issue Apr 5, 2023 · 4 comments
Open
4 tasks done

About preview functionality bugs which seems have been fixed #3405

clichedmoog opened this issue Apr 5, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good Issue for newcomers investigating web-previews Related to preview branches

Comments

@clichedmoog
Copy link

Before opening, please confirm:

App Id

https://ap-northeast-2.console.aws.amazon.com/amplify/home?region=ap-northeast-2#/d2jveo7g4jys2l

AWS Region

ap-northeast-2

Amplify Hosting feature

Web previews

Question

I have some questions about the bugs that seemed to have been fixed.

In the past, I was annoyed by certain issues, including the fact that resources (such as S3, Lambda@Edge, and CloudFront) were not deleted even after the preview was closed (issues #2424, #2273, and #2123).

Additionally, I noticed that the PR checks from GitHub remained "In progress" or “failed” when they failed and were redeployed in Amplify.
And cannot re-trigger builds with click the “re-run” button from GitHub (issues #367 #3287, #3261)

When I reached out to AWS support using a support case, they indicated that these issues seemed to have been resolved, but were not entirely certain.

Could you confirm whether or not these preview-related bugs have indeed been fixed?

@clichedmoog clichedmoog added the question Further information is requested label Apr 5, 2023
@clichedmoog
Copy link
Author

clichedmoog commented Apr 5, 2023

With simple testing, "PR checks not updating by amplify" issues might occur again or have not been fixed yet.

@ghost
Copy link

ghost commented Apr 5, 2023

Hi @clichedmoog thanks for bringing this to our attention. We are investigating these issues further to determine next steps. We will update this issue once we have reproduced/tested these mechanisms again.

@pasihu
Copy link

pasihu commented Apr 11, 2023

They have not been fixed. There are multiple problems with preview feature that are incredibly annoying:

  1. You cannot re-run builds from github. You will have to log in to AWS to manually check which build is failing.
  2. Failed build status will not update in github. After you re-run your builds successfully in AWS the status will not change in github. Do you have a rule preventing you from merging without a passing build? Too bad!
  3. The github bot deployment message cannot be edited and the url that it does provide cannot be customized. Our PRs generate 4 different preview deployments. The only way to tell them apart from the preview url is to memorize the amplify app id. 🥴 I actually had to make my own bot message that will provide URLs to preview environments with some explanation what is being deployed.
  4. The bot deployment message can not be turned off. We have 4 deployments per PR so we will get that many useless bot messages in the PR.

@ghost ghost added bug Something isn't working and removed question Further information is requested labels Apr 20, 2023
@arundna arundna added the good first issue Good Issue for newcomers label Apr 24, 2023
@nadetastic nadetastic self-assigned this May 2, 2023
@nadetastic nadetastic added investigating web-previews Related to preview branches labels May 3, 2023
@nadetastic nadetastic assigned ghost and unassigned nadetastic Jun 12, 2023
@ghost ghost removed their assignment Jul 7, 2023
@jackykwandesign
Copy link

They have not been fixed. There are multiple problems with preview feature that are incredibly annoying:

  1. You cannot re-run builds from github. You will have to log in to AWS to manually check which build is failing.

  2. Failed build status will not update in github. After you re-run your builds successfully in AWS the status will not change in github. Do you have a rule preventing you from merging without a passing build? Too bad!

  3. The github bot deployment message cannot be edited and the url that it does provide cannot be customized. Our PRs generate 4 different preview deployments. The only way to tell them apart from the preview url is to memorize the amplify app id. 🥴 I actually had to make my own bot message that will provide URLs to preview environments with some explanation what is being deployed.

  4. The bot deployment message can not be turned off. We have 4 deployments per PR so we will get that many useless bot messages in the PR.

same feeling

We are running monorepo with 3 web app deploying on amplify and hard to identify the url

No expecting to customise but please at least include project name in the message so easier to identify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good Issue for newcomers investigating web-previews Related to preview branches
Projects
None yet
Development

No branches or pull requests

5 participants