Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: amplify console hosting plugin #3525

Merged
merged 6 commits into from
Mar 5, 2020
Merged

feat: amplify console hosting plugin #3525

merged 6 commits into from
Mar 5, 2020

Conversation

garyleefight
Copy link
Contributor

hosting plugin with e2e test cases

@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #3525 into master will decrease coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3525      +/-   ##
==========================================
- Coverage   59.71%   58.87%   -0.84%     
==========================================
  Files         285      286       +1     
  Lines       13140    13327     +187     
  Branches     2491     2515      +24     
==========================================
  Hits         7846     7846              
- Misses       4889     5076     +187     
  Partials      405      405
Impacted Files Coverage Δ
...ges/amplify-util-mock/src/utils/config-override.ts
...ackages/amplify-util-mock/src/utils/lambda/load.ts
...l-mock/src/CFNParser/resource-processors/lambda.ts
...mplify-util-mock/src/__e2e__/utils/test-storage.ts
...amplify-util-mock/src/utils/mock-data-directory.ts
...plify-util-mock/src/__e2e__/utils/lambda-helper.ts
packages/amplify-util-mock/src/api/index.ts 0% <0%> (ø)
packages/amplify-util-mock/src/utils/index.ts 0% <0%> (ø)
packages/amplify-util-mock/src/api/api.ts 0% <0%> (ø)
...ages/amplify-util-mock/src/utils/lambda/execute.ts 0% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1438f71...9ff66ea. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2020

This pull request introduces 2 alerts when merging b1bce5f into 93fefe9 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Copy link
Contributor

@swaminator swaminator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the feedback

packages/amplify-console-hosting/amplify-plugin.json Outdated Show resolved Hide resolved
packages/amplify-console-hosting/commands/help.js Outdated Show resolved Hide resolved
packages/amplify-console-hosting/hosting/index.js Outdated Show resolved Hide resolved
packages/amplify-console-hosting/hosting/index.js Outdated Show resolved Hide resolved
packages/amplify-console-hosting/hosting/index.js Outdated Show resolved Hide resolved
packages/amplify-console-hosting/utils/build-utils.js Outdated Show resolved Hide resolved
@garyleefight
Copy link
Contributor Author

Fixed all

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2020

This pull request introduces 2 alerts when merging f8a9848 into aa391ef - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2020

This pull request introduces 2 alerts when merging bc79477 into bc4a1d9 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Copy link
Contributor

@UnleashedMind UnleashedMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, avoid directly using console.log, but use the context.print for consistency.
Also change the commands or alias definitions to make two hosting plugins the same in the command list.

@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2020

This pull request introduces 2 alerts when merging 84c8b86 into bc4a1d9 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2020

This pull request introduces 2 alerts when merging 1696bbe into bc4a1d9 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2020

This pull request introduces 2 alerts when merging 9ff66ea into 208c08f - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

Copy link
Contributor

@UnleashedMind UnleashedMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaustavghosh06 kaustavghosh06 merged commit 2c84b71 into aws-amplify:master Mar 5, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants