-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: amplify console hosting plugin #3525
Conversation
This pull request introduces 2 alerts when merging b1bce5f into 93fefe9 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the feedback
packages/amplify-console-hosting/constants/question-constants.js
Outdated
Show resolved
Hide resolved
packages/amplify-console-hosting/constants/question-constants.js
Outdated
Show resolved
Hide resolved
packages/amplify-console-hosting/constants/question-constants.js
Outdated
Show resolved
Hide resolved
packages/amplify-console-hosting/utils/amplify-console-utils.js
Outdated
Show resolved
Hide resolved
Fixed all |
This pull request introduces 2 alerts when merging f8a9848 into aa391ef - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging bc79477 into bc4a1d9 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, avoid directly using console.log, but use the context.print for consistency.
Also change the commands or alias definitions to make two hosting plugins the same in the command list.
packages/amplify-console-hosting/hosting/templates/amplifyhosting-template.json
Outdated
Show resolved
Hide resolved
This pull request introduces 2 alerts when merging 84c8b86 into bc4a1d9 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 1696bbe into bc4a1d9 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 9ff66ea into 208c08f - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
hosting plugin with e2e test cases