Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the xml declaration line #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francois-travais
Copy link

@francois-travais francois-travais commented Sep 21, 2021

Like for the bash shebang (#!), an xml declaration tag like so <?xml ?> should be the first instruction.

One drawback is that there's not necessarily a newline after <?xml ?>

@awjh
Copy link
Owner

awjh commented Oct 27, 2021

Hello, apologies for the slow response. Do you think you could update this in a way that handles the fact there may not be a new line? There would also need to be tests around adding this, both unit and integration. I would suggest adding for the integration tests an xml file in the non-regex folder, one in the original files and one in the goal files.

Thank you for taking the time to PR into this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants