Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification icons #176

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Add notification icons #176

merged 2 commits into from
Jan 15, 2025

Conversation

sharlotta93
Copy link
Contributor

@sharlotta93 sharlotta93 commented Jan 15, 2025

PR Type

Enhancement


Description

  • Added new notification and square icons to the icon types.

  • Updated the package.json version to 0.12.32.


Changes walkthrough 📝

Relevant files
Enhancement
types.ts
Add new notification and square icons                                       

src/components/ui/icon/types.ts

  • Added RiNotification2Line and RiNotification2Fill icons.
  • Added RiSquareFill and RiSquareLine icons.
  • Updated the ICONS export to include the new icons.
  • +8/-0     
    Configuration changes
    package.json
    Update package version to 0.12.32                                               

    package.json

    • Updated the version from 0.12.31 to 0.12.32.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Test Coverage

    Ensure that the newly added icons (RiNotification2Line, RiNotification2Fill, RiSquareFill, RiSquareLine) are properly tested and integrated into the system to avoid potential issues with their usage.

      RiNotification2Line,
      RiNotification2Fill,
      RiLayout3Line,
      RiLifebuoyLine,
      RiLineChartLine,
      RiListCheck,
      RiListCheck3,
      RiListOrdered2,
      RiLogoutBoxRLine,
      RiMailLine,
      RiMessage3Fill,
      RiMore2Line,
      RiNodeTree,
      RiPhoneLine,
      RiPlayFill,
      RiPriceTag3Fill,
      RiPulseFill,
      RiPuzzleFill,
      RiQuestionFill,
      RiQuestionLine,
      RiQuoteText,
      RiRadioButtonLine,
      RiRefreshLine,
      RiResetLeftLine,
      RiSaveLine,
      RiSearchLine,
      RiSettings4Line,
      RiShareLine,
      RiSparklingFill,
      RiSparklingLine,
      RiSquareFill,
      RiSquareLine,
      RiStethoscopeLine,
      RiStickyNote2Fill,
      RiStopCircleFill,
      RiSubtractFill,
      RiSurveyFill,
      RiTerminalBoxFill,
      RiTerminalWindowFill,
      RiTestTubeFill,
      RiTestTubeLine,
      RiText,
      RiTextSnippet,
      RiTimerLine,
      RiTimeFill,
      RiTimeLine,
      RiThumbDownFill,
      RiThumbDownLine,
      RiThumbUpFill,
      RiThumbUpLine,
      RiToolsLine,
      RiUploadCloudFill,
      RiUploadLine,
      RiUserFill,
      RiUserLine,
      RiZoomInLine,
      RiZoomOutLine,
      RiEyeLine,
      RiEyeFill,
      RiPhoneFill
    } from '@remixicon/react';
    
    export const ICONS = {
      RiAccountPinBoxFill,
      RiAddFill,
      RiAlertFill,
      RiAlertLine,
      RiArrowDownLine,
      RiArrowDownSLine,
      RiArrowDropRightLine,
      RiArrowGoBackLine,
      RiArrowLeftDoubleFill,
      RiArrowLeftLine,
      RiArrowLeftRightFill,
      RiArrowLeftRightLine,
      RiArrowLeftSLine,
      RiArrowRightLine,
      RiArrowRightSLine,
      RiArrowRightUpLine,
      RiArrowUpLine,
      RiArrowUpSLine,
      RiArticleLine,
      RiAttachmentLine,
      RiBillLine,
      RiBookmarkLine,
      RiBracesLine,
      RiCalculatorFill,
      RiCalendar2Line,
      RiCalendarLine,
      RiCheckboxFill,
      RiCheckboxLine,
      RiCheckboxMultipleFill,
      RiCheckFill,
      RiCheckLine,
      RiCloseFill,
      RiCloseLargeLine,
      RiCloseLine,
      RiCodeFill,
      RiCoinLine,
      RiCollapseDiagonal2Line,
      RiCollapseHorizontalLine,
      RiCollapseVerticalLine,
      RiContractRightLine,
      RiCursorFill,
      RiDatabase2Line,
      RiDeleteBin6Fill,
      RiDeleteBinFill,
      RiDeleteBinLine,
      RiDossierLine,
      RiDownloadLine,
      RiDraggable,
      RiEdit2Fill,
      RiEditCircleLine,
      RiEqualizer2Line,
      RiErrorWarningFill,
      RiErrorWarningLine,
      RiExpandDiagonal2Line,
      RiExpandHorizontalLine,
      RiExpandVerticalLine,
      RiExternalLinkLine,
      RiFileCopyFill,
      RiFileLine,
      RiGlobalLine,
      RiGlobeLine,
      RiHashtag,
      RiHealthBookFill,
      RiHeartPulseLine,
      RiHistoryLine,
      RiHomeLine,
      RiInformation2Fill,
      RiInformationLine,
      RiNotification2Line,
      RiNotification2Fill,
      RiLayout3Line,
      RiLifebuoyLine,
      RiLineChartLine,
      RiListCheck,
      RiListCheck3,
      RiListOrdered2,
      RiLogoutBoxRLine,
      RiMailLine,
      RiMessage3Fill,
      RiMore2Line,
      RiNodeTree,
      RiPhoneLine,
      RiPlayFill,
      RiPriceTag3Fill,
      RiPulseFill,
      RiPuzzleFill,
      RiQuestionFill,
      RiQuestionLine,
      RiQuoteText,
      RiRadioButtonLine,
      RiRefreshLine,
      RiResetLeftLine,
      RiSaveLine,
      RiSearchLine,
      RiSettings4Line,
      RiShareLine,
      RiSparklingFill,
      RiSparklingLine,
      RiSquareFill,
      RiSquareLine,

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Verify that newly added icons are integrated and tested to prevent unused imports or functionality issues

    Ensure that the newly added icons RiNotification2Line, RiNotification2Fill,
    RiSquareFill, and RiSquareLine are properly tested and used in the application to
    avoid unused imports or potential integration issues.

    src/components/ui/icon/types.ts [70-101]

     +  RiNotification2Line,
     +  RiNotification2Fill,
     ...
     +  RiSquareFill,
     +  RiSquareLine,
    +// Ensure these icons are utilized and tested in the application
    Suggestion importance[1-10]: 4

    Why: While the suggestion to ensure the new icons are tested and used is valid, it is not actionable within the code itself and does not directly improve the code quality. It serves as a reminder rather than a concrete enhancement, which limits its impact.

    4

    @sharlotta93 sharlotta93 merged commit c6710bb into main Jan 15, 2025
    2 checks passed
    @sharlotta93 sharlotta93 deleted the add-notification-icons branch January 15, 2025 20:21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant