Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons & version #142

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update icons & version #142

merged 1 commit into from
Oct 24, 2024

Conversation

skrobek
Copy link
Collaborator

@skrobek skrobek commented Oct 24, 2024

PR Type

enhancement, other


Description

  • Added new icons RiCollapseVerticalLine and RiExpandVerticalLine to the icon types in the design system.
  • Updated the package version in package.json from 0.11.1 to 0.11.2.

Changes walkthrough 📝

Relevant files
Enhancement
types.ts
Add new vertical line icons to the ICONS export                   

src/components/ui/icon/types.ts

  • Added RiCollapseVerticalLine and RiExpandVerticalLine icons to
    imports.
  • Updated the ICONS export to include new vertical line icons.
  • +6/-2     
    Other
    package.json
    Bump package version to 0.11.2                                                     

    package.json

    • Updated the package version from 0.11.1 to 0.11.2.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Duplication
    The new icons RiCollapseVerticalLine and RiExpandVerticalLine are added twice in the same file, which might be a mistake or unnecessary duplication.

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @skrobek skrobek merged commit 8fb7496 into main Oct 24, 2024
    2 checks passed
    @skrobek skrobek deleted the chart-icons branch December 17, 2024 09:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant