Feature: Cleanup Removed Images #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be on dehydration instead? I'm worried that doing it on stateUpdate will break if the user accidentally deletes the image and then restores it with the undo. |
|
Good point. Can't see any reason against moving it to dehydration. I guess we have old/new data there also? |
|
Haven't forgotten about this, I'm just still not sure it's a plug-in responsibility. Just seems more like an app responsibility. |
|
It might be best, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Feature: Optionally Cleanup Removed Images
This PR introduces automatic cleanup of images that are removed from the Tiptap editor content. When an image is deleted from the editor, the corresponding file is also removed from the storage disk. This ensures that unused images do not accumulate, saving disk space and maintaining a clean storage environment.
TiptapEditor::make('foo')->cleanUpDeletedImages()