fix: enable module loading for custom extensions #531
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the package loads custom extension scripts as regular JavaScript files, which prevents the use of ES module syntax (
import
statements). This means even the example snippet in the docs will not work, nor will using extensions from packages like@tiptap-pro
, be very straighforward to useThis code fails with
Uncaught SyntaxError: Cannot use import statement outside a module
.This PR modifies the asset registration to load custom extension scripts as modules by using Filament's
module()
method, allowing one to use ES module syntax in their extension scripts