-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
img
attributes to facilitate the use of Responsive Images & Media Libraries
#524
Conversation
- src / size are for responsive image support a la Spatie Media Library - data-media-id is for storing / parsing IDs used by a Media Library of any sort
img
attributes to facilitate the use of Responsive Images & Media Libraries
Where would the srcset and sizes be defined? |
These would be provided by the The most notable example being Spatie's media library which generates responsive images, as well as any packages which extend its functionality like Ralph J Smit's Media Library Manager. I can look at modify this PR to have the default actions potentially provide an option to fill in the |
I'm ok with them not being default. Prefer it that way. Should the Readme cover the usage though? Also need to make sure it's doesn't break anything with Curator. |
I can update the readme to mention the new attributes. |
Readme updated to give a quick explanation of the new attributes. |
For #249
Recreation of #489
The reason I recreated this was due to inactivity on the other PR, and to split the media item changes into a PR separate from adding a new iFrame node.
The iFrame node would still be beneficial, in my opinion, but I'll let @rubenlopezgea-at-coodex manage that.