Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't check action's authorization on render if visible return false #3628

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3626

Don't check action's authorization on render if visible return false

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Jan 31, 2025
@github-actions github-actions bot added the Fix label Jan 31, 2025
Copy link

codeclimate bot commented Jan 31, 2025

Code Climate has analyzed commit 0f310ca and detected 0 issues on this pull request.

View more on Code Climate.

lib/avo/base_action.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit c717dce into main Jan 31, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/action_authorization branch January 31, 2025 12:41
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action authorize proc being called even if self.visible is false
1 participant