Modified Examples to reflect new public Api #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified auth net example to use new api without payment worker. Changed config to use new key.
Modified example files for gateways to remove :payment_worker usage.
oyeb
approved these changes
Jan 2, 2018
| @amount 20.00 | ||
|
|
||
| def authorize() do | ||
| case Billing.authorize(AuthorizeNet, @amount, @card, @opts) do |
There was a problem hiding this comment.
The case block is not serving any purpose, and can be removed. This will make your functions consistent with those in other gateways too.
oyeb
approved these changes
Jan 2, 2018
| @@ -5,7 +5,7 @@ defmodule Gringotts.Examples.Mixfile do | |||
| [ | |||
| app: :gringotts_examples, | |||
| version: "0.1.0", | |||
| elixir: "~> 1.5.2", | |||
| elixir: "~> 1.5.1", | |||
There was a problem hiding this comment.
@oyeb yes, we have to support almost all widely used versions have to spend some time on it. Testing is easier on travis. they support multiple version testing AFAIK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following points are covered in this request.
:payment_worker.